fix: Remove incorrect line from submission API info web page#6432
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Oct 9, 2023
Merged
fix: Remove incorrect line from submission API info web page#6432rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
DavidSchinazi
changed the title
jennifer-richards
requested changes
Oct 4, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Thank you for the patch - as noted inline, only the asynchronous endpoint (api_submission) accepts replacement information so we should probably keep the comment on the old endpoint's docs.
| </p> | ||
| <ul> | ||
| <li>Only XML-only uploads are supported, not text or combined.</li> | ||
| <li>Document replacement information cannot be supplied.</li> |
Member
There was a problem hiding this comment.
This one needs to stay - the replaces is only supported through the asynchronous endpoint.
Contributor
Author
There was a problem hiding this comment.
Ah good catch, thanks! Fixed.
jennifer-richards
approved these changes
Oct 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #6432 +/- ##
==========================================
- Coverage 88.81% 88.69% -0.12%
==========================================
Files 290 290
Lines 40879 40429 -450
==========================================
- Hits 36305 35857 -448
+ Misses 4574 4572 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #4037 has landed and #3286 has been resolved, this line can be removed.